Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#17] Add HslColor module #78

Merged
merged 1 commit into from
Sep 27, 2022
Merged

[#17] Add HslColor module #78

merged 1 commit into from
Sep 27, 2022

Conversation

newswim
Copy link
Collaborator

@newswim newswim commented Sep 27, 2022

Closes #17

Copy link
Owner

@jacob-alford jacob-alford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

'hsl(270 60% 70%)',
'hsl(200, +.1e-9%, 62e10%, 1)',
'hsl(.75turn, 60%, 70%)',
// 'hsl(200grad+.1%62%/1)', //supposed to pass, but need to handle delimiters
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Is this just strange because it has no spaces or commas?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you can use + as a delimiter 🤮

hsl(50+80%40%/.6);

@newswim newswim merged commit 1d0390c into main Sep 27, 2022
@newswim newswim deleted the dm/add-hsl-module branch September 27, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HSL string module
2 participants