Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#49] Add fast-check, add ArbitraryBase > Schemable #50

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

jacob-alford
Copy link
Owner

Closes #49

newswim
newswim previously approved these changes Sep 21, 2022
Copy link
Collaborator

@newswim newswim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

newswim
newswim previously approved these changes Sep 22, 2022
Copy link
Collaborator

@newswim newswim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

import * as Arb from '../src/internal/ArbitraryBase'
import { isPositiveFloat } from '../src/number/PositiveFloat'

const typeOf: (a: unknown) => string = a => (a === null ? 'null' : typeof a)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think you no longer need to define this here since it's exported from ArbitraryBase.ts

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh true!

@newswim newswim merged commit a84d744 into main Sep 22, 2022
@newswim newswim deleted the jalford/49/add-arbitrary branch September 22, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fast-check (peer-dep), and Arbitrary schemable instance
2 participants