[fix](memtracking) require size in Allocator::free (apache#27795)

jackwener · Nov 30, 2023 · 8ca8a06 · 8ca8a06
1 parent db8e56b
commit 8ca8a06
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/be/src/util/slice.h b/be/src/util/slice.h
@@ -336,7 +336,7 @@ class OwnedSlice : private Allocator<false, false, false> {
         return *this;
     }
 
-    ~OwnedSlice() { Allocator::free(_slice.data); }
+    ~OwnedSlice() { Allocator::free(_slice.data, _slice.size); }
 
     const Slice& slice() const { return _slice; }
 

diff --git a/be/src/vec/common/allocator.h b/be/src/vec/common/allocator.h
@@ -142,9 +142,8 @@ class Allocator {
     }
 
     /// Free memory range.
-    void free(void* buf, size_t size = -1) {
+    void free(void* buf, size_t size) {
         if (use_mmap && size >= doris::config::mmap_threshold) {
-            DCHECK(size != -1);
             if (0 != munmap(buf, size)) {
                 throw_bad_alloc(fmt::format("Allocator: Cannot munmap {}.", size));
             }