fix(antigravity): implement configurable timeout and auto-reconnect for serve#859
fix(antigravity): implement configurable timeout and auto-reconnect for serve#859deepziyu wants to merge 4 commits intojackwener:mainfrom
Conversation
|
I think this PR is moving in the right direction overall. Making the My main concern is the new reconnect path in So from a design point of view, I like the direction of configurable timeout plus reconnect, but I think the reconnect policy needs a tighter boundary. I would limit retry to explicit transport or session-loss errors and rethrow everything else. |
…g and max retries
|
Refined the reconnection logic in waitForReply as suggested:
|
|
I checked the latest head. The reconnect change looks much better now. Restricting retries to session-loss-style errors and rethrowing other failures addresses the concern I raised earlier about masking DOM or selector bugs behind a later timeout. I still see one separate issue with the new timeout handling. In |
|
Thank you for the detailed feedback, @Astro-Han! I have standardized the timeout parsing as suggested:
|
Resolves #861
Resolves the 120s hardcoded timeout issue and CDP connection exclusion problem in \�ntigravity serve\ command. Adds --timeout\ option and \OPENCLI_ANTIGRAVITY_TIMEOUT\ support. Implements auto-reconnect logic via \�nsureConnected\ during polling.