Skip to content

feat:add 1688 assets downloadable#820

Merged
jackwener merged 2 commits intojackwener:mainfrom
BruceLoveDecimal:feat/1688_assets
Apr 5, 2026
Merged

feat:add 1688 assets downloadable#820
jackwener merged 2 commits intojackwener:mainfrom
BruceLoveDecimal:feat/1688_assets

Conversation

@BruceLoveDecimal
Copy link
Copy Markdown
Contributor

Description

Add a minimal first-pass solution for exporting media assets from 1688 item pages.

This PR adds:

  • opencli 1688 assets <url-or-offer-id>
  • opencli 1688 download <url-or-offer-id>

The implementation focuses on the user goal first by extracting page-visible media from the item page itself, instead of trying to automate the official 1688 extension popup / iframe UI directly.

Related issue: #811

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🌐 New site adapter
  • 📝 Documentation
  • ♻️ Refactor
  • 🔧 CI / build / tooling

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • I included output or screenshots when useful

Documentation (if adding/modifying an adapter)

  • Added doc page under docs/adapters/ (if new adapter)
  • Updated docs/adapters/index.md table (if new adapter)
  • Updated sidebar in docs/.vitepress/config.mts (if new adapter)
  • Updated README.md / README.zh-CN.md when command discoverability changed
  • Used positional args for the command's primary subject unless a named flag is clearly better
  • Normalized expected adapter failures to CliError subclasses instead of raw Error

刘启灏 and others added 2 commits April 6, 2026 00:57
…Url re-export

- Remove unused outer `visitedRoots` variable in scriptToReadAssets()
- Move normalizeMediaUrl test to import from shared.ts where it's defined
- Remove unused normalizeMediaUrl import from assets.ts
@jackwener jackwener merged commit d2ae287 into jackwener:main Apr 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants