Skip to content

fix: add -v/--verbose to explore, record, generate, cascade#719

Merged
jackwener merged 4 commits intojackwener:mainfrom
Astro-Han:worktree-fix-explore-verbose
Apr 4, 2026
Merged

fix: add -v/--verbose to explore, record, generate, cascade#719
jackwener merged 4 commits intojackwener:mainfrom
Astro-Han:worktree-fix-explore-verbose

Conversation

@Astro-Han
Copy link
Copy Markdown
Contributor

Description

Built-in browser commands (explore, record, generate, cascade) are registered directly in cli.ts and missed the -v/--verbose flag that commanderAdapter.ts wires up for adapter commands. This PR adds the flag to all four commands using the same process.env.OPENCLI_VERBOSE = '1' pattern.

Also switches the lone log.debug() in explore.ts to log.verbose() so the flag has visible effect.

Related issue: #716

Type of Change

  • 🐛 Bug fix

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • I included output or screenshots when useful

Astro-Han and others added 2 commits April 3, 2026 16:57
Built-in browser commands were registered directly in cli.ts and
missed the -v/--verbose flag that commanderAdapter.ts wires up for
adapter commands. Also switch explore's lone log.debug() call to
log.verbose() so the flag has visible effect.

Closes jackwener#716
@jackwener jackwener force-pushed the worktree-fix-explore-verbose branch from b074cd3 to 25b93a8 Compare April 3, 2026 09:01
Replace registerVerboseAction wrapper with simple applyVerbose() helper.
The wrapper broke Commander's builder chain and created awkward
indentation. Now each command uses standard .option().action() with
applyVerbose(opts) as the first line — easier to read and maintain.
These commands were also missing verbose support, same root cause as
explore/record/generate/cascade — registered directly in cli.ts,
bypassing commanderAdapter's automatic -v wiring.
@jackwener jackwener merged commit ef78aaf into jackwener:main Apr 4, 2026
11 checks passed
just-buer pushed a commit to just-buer/opencli that referenced this pull request Apr 8, 2026
* fix: add -v/--verbose to explore, record, generate, cascade

Built-in browser commands were registered directly in cli.ts and
missed the -v/--verbose flag that commanderAdapter.ts wires up for
adapter commands. Also switch explore's lone log.debug() call to
log.verbose() so the flag has visible effect.

Closes jackwener#716

* refactor(cli): make builtin command wiring testable

* refactor(cli): simplify verbose wiring, use normal Commander pattern

Replace registerVerboseAction wrapper with simple applyVerbose() helper.
The wrapper broke Commander's builder chain and created awkward
indentation. Now each command uses standard .option().action() with
applyVerbose(opts) as the first line — easier to read and maintain.

* fix(cli): add -v/--verbose to doctor and synthesize commands

These commands were also missing verbose support, same root cause as
explore/record/generate/cascade — registered directly in cli.ts,
bypassing commanderAdapter's automatic -v wiring.

---------

Co-authored-by: jackwener <jakevingoo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants