Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/browser/base-page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ export abstract class BasePage implements IPage {
abstract getCookies(opts?: { domain?: string; url?: string }): Promise<BrowserCookie[]>;
abstract screenshot(options?: ScreenshotOptions): Promise<string>;
abstract tabs(): Promise<unknown[]>;
abstract closeTab(index?: number): Promise<void>;
abstract newTab(): Promise<void>;
abstract selectTab(index: number): Promise<void>;

// ── Shared DOM helper implementations ──
Expand Down
8 changes: 0 additions & 8 deletions src/browser/cdp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,14 +223,6 @@ class CDPPage extends BasePage {
return [];
}

async closeTab(_index?: number): Promise<void> {
// Not supported in direct CDP mode
}

async newTab(): Promise<void> {
await this.bridge.send('Target.createTarget', { url: 'about:blank' });
}

async selectTab(_index: number): Promise<void> {
// Not supported in direct CDP mode
}
Expand Down
12 changes: 0 additions & 12 deletions src/browser/page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,18 +129,6 @@ export class Page extends BasePage {
return Array.isArray(result) ? result : [];
}

async closeTab(index?: number): Promise<void> {
await sendCommand('tabs', { op: 'close', ...this._wsOpt(), ...(index !== undefined ? { index } : {}) });
// Invalidate cached tabId — the closed tab might have been our active one.
// We can't know for sure (close-by-index doesn't return tabId), so reset.
this._tabId = undefined;
}

async newTab(): Promise<void> {
const result = await sendCommand('tabs', { op: 'new', ...this._wsOpt() }) as { tabId?: number };
if (result?.tabId) this._tabId = result.tabId;
}

async selectTab(index: number): Promise<void> {
const result = await sendCommand('tabs', { op: 'select', index, ...this._wsOpt() }) as { selected?: number };
if (result?.selected) this._tabId = result.selected;
Expand Down
1 change: 0 additions & 1 deletion src/clis/douyin/_shared/browser-fetch.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ function makePage(result: unknown): IPage {
getCookies: vi.fn(), snapshot: vi.fn(), click: vi.fn(),
typeText: vi.fn(), pressKey: vi.fn(), scrollTo: vi.fn(),
getFormState: vi.fn(), wait: vi.fn(), tabs: vi.fn(),
closeTab: vi.fn(), newTab: vi.fn(), selectTab: vi.fn(),
networkRequests: vi.fn(), consoleMessages: vi.fn(),
scroll: vi.fn(), autoScroll: vi.fn(),
installInterceptor: vi.fn(), getInterceptedRequests: vi.fn(),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/douyin/_shared/transcode.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ function makePage(): IPage {
getFormState: vi.fn(),
wait: vi.fn(),
tabs: vi.fn(),
closeTab: vi.fn(),
newTab: vi.fn(),
selectTab: vi.fn(),
networkRequests: vi.fn(),
consoleMessages: vi.fn(),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/douyin/draft.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ function createPageMock(
getFormState: vi.fn().mockResolvedValue({ forms: [], orphanFields: [] }),
wait: vi.fn().mockResolvedValue(undefined),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn().mockResolvedValue(undefined),
newTab: vi.fn().mockResolvedValue(undefined),
selectTab: vi.fn().mockResolvedValue(undefined),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/facebook/search.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ function createMockPage(): IPage {
getFormState: vi.fn().mockResolvedValue({}),
wait: vi.fn(),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn(),
newTab: vi.fn(),
selectTab: vi.fn(),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue(''),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/substack/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ function createPageMock(evaluateResult: unknown): IPage {
getFormState: vi.fn().mockResolvedValue({}),
wait: vi.fn().mockResolvedValue(undefined),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn().mockResolvedValue(undefined),
newTab: vi.fn().mockResolvedValue(undefined),
selectTab: vi.fn().mockResolvedValue(undefined),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/xiaohongshu/comments.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ function createPageMock(evaluateResult: any): IPage {
getFormState: vi.fn().mockResolvedValue({ forms: [], orphanFields: [] }),
wait: vi.fn().mockResolvedValue(undefined),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn().mockResolvedValue(undefined),
newTab: vi.fn().mockResolvedValue(undefined),
selectTab: vi.fn().mockResolvedValue(undefined),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/xiaohongshu/creator-note-detail.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ function createPageMock(evaluateResult: any): IPage {
getFormState: vi.fn().mockResolvedValue({ forms: [], orphanFields: [] }),
wait: vi.fn().mockResolvedValue(undefined),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn().mockResolvedValue(undefined),
newTab: vi.fn().mockResolvedValue(undefined),
selectTab: vi.fn().mockResolvedValue(undefined),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/xiaohongshu/creator-notes.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ function createPageMock(evaluateResult: any, interceptedRequests: any[] = []): I
getFormState: vi.fn().mockResolvedValue({ forms: [], orphanFields: [] }),
wait: vi.fn().mockResolvedValue(undefined),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn().mockResolvedValue(undefined),
newTab: vi.fn().mockResolvedValue(undefined),
selectTab: vi.fn().mockResolvedValue(undefined),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/xiaohongshu/download.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ function createPageMock(evaluateResult: any): IPage {
getFormState: vi.fn().mockResolvedValue({ forms: [], orphanFields: [] }),
wait: vi.fn().mockResolvedValue(undefined),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn().mockResolvedValue(undefined),
newTab: vi.fn().mockResolvedValue(undefined),
selectTab: vi.fn().mockResolvedValue(undefined),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/xiaohongshu/note.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ function createPageMock(evaluateResult: any): IPage {
getFormState: vi.fn().mockResolvedValue({ forms: [], orphanFields: [] }),
wait: vi.fn().mockResolvedValue(undefined),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn().mockResolvedValue(undefined),
newTab: vi.fn().mockResolvedValue(undefined),
selectTab: vi.fn().mockResolvedValue(undefined),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/xiaohongshu/publish.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ function createPageMock(evaluateResults: any[], overrides: Partial<IPage> = {}):
getFormState: vi.fn().mockResolvedValue({ forms: [], orphanFields: [] }),
wait: vi.fn().mockResolvedValue(undefined),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn().mockResolvedValue(undefined),
newTab: vi.fn().mockResolvedValue(undefined),
selectTab: vi.fn().mockResolvedValue(undefined),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/clis/xiaohongshu/search.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ function createPageMock(evaluateResults: any[]): IPage {
getFormState: vi.fn().mockResolvedValue({ forms: [], orphanFields: [] }),
wait: vi.fn().mockResolvedValue(undefined),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn().mockResolvedValue(undefined),
newTab: vi.fn().mockResolvedValue(undefined),
selectTab: vi.fn().mockResolvedValue(undefined),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/pipeline/executor.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ function createMockPage(overrides: Partial<IPage> = {}): IPage {
getFormState: vi.fn().mockResolvedValue({}),
wait: vi.fn(),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn(),
newTab: vi.fn(),
selectTab: vi.fn(),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue(''),
Expand Down
2 changes: 0 additions & 2 deletions src/pipeline/steps/download.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ function createMockPage(getCookies: IPage['getCookies']): IPage {
getFormState: vi.fn().mockResolvedValue({}),
wait: vi.fn(),
tabs: vi.fn().mockResolvedValue([]),
closeTab: vi.fn(),
newTab: vi.fn(),
selectTab: vi.fn(),
networkRequests: vi.fn().mockResolvedValue([]),
consoleMessages: vi.fn().mockResolvedValue([]),
Expand Down
2 changes: 0 additions & 2 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ export interface IPage {
getFormState(): Promise<any>;
wait(options: number | WaitOptions): Promise<void>;
tabs(): Promise<any>;
closeTab(index?: number): Promise<void>;
newTab(): Promise<void>;
selectTab(index: number): Promise<void>;
networkRequests(includeStatic?: boolean): Promise<any>;
consoleMessages(level?: string): Promise<any>;
Expand Down
Loading