fix(e2e): remove duplicate closing bracket causing vite:oxc parse error#361
Merged
fix(e2e): remove duplicate closing bracket causing vite:oxc parse error#361
Conversation
The dictionary adapters commit (3d39574) introduced a duplicate `}, 30_000);` at line 524 of public-commands.test.ts, causing the vite:oxc transformer to fail with [PARSE_ERROR] Unexpected token in the E2E Headed Chrome CI workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The E2E Headed Chrome CI workflow fails with:
Root Cause
Commit 3d39574 (PR #241 — dictionary adapters) introduced a duplicate
}, 30_000);at line 524 ofpublic-commands.test.ts. The OXC transformer sees an extra closing bracket and fails to parse.Fix
Remove the extraneous line. One-line deletion.