Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overriding the remote read path #261

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

BertHartm
Copy link
Contributor

m3 uses a different path than the one that was hardcoded into promxy (ref: https://m3db.github.io/m3/coordinator/api/remote/#remote-read), so this allows setting the path in the config by server group.

This seems like it would potentially make path_prefix removable. I didn't attempt to remove for the sake of backwards compatibility.

@jacksontj
Copy link
Owner

We'll want to keep the path_prefix option as it applies to all the URLs downstream (remote_read, query, query_range, etc.) -- the use-case for that is when the promAPI is behind some proxy (somewhat common for those with lots of firewalls).

That all being said, this seems like a fine feature -- mind rebasing against latest master? Once thats done I can merge it in :)

@jacksontj jacksontj self-assigned this Jan 21, 2020
@BertHartm
Copy link
Contributor Author

Sounds good, just rebased.

Thanks

@jacksontj jacksontj merged commit 1d6a6d8 into jacksontj:master Jan 21, 2020
@jacksontj
Copy link
Owner

Awesome, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants