Copy disk labels to snapshot labels #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from upstream
|
Hi @timwsuqld , Thanks for the PR - can you give one-liner on what you've added? Also, would be great if you could update the README with your new option. Cheers, |
|
@jacksegal I've pushed another commit. Basically, we just list all the labels of the source disk, and apply those to the snapshot. Useful for filtering snapshots based on the original disk labels. (We actually backup our snapshots with another tool, so having the labels help us find the snapshots we actually want backed up) |
|
Thanks @timwsuqld - looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to copy labels from a disk onto the snapshot labels