Show warning when user is prevented from allowing to zoom #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add warning message (new _head.scss file) - Update code - Update demo page - Add cypress test - Build the library
2 tasks
jackdomleo7
requested changes
Jan 11, 2022
Owner
jackdomleo7
left a comment
jackdomleo7
left a comment
There was a problem hiding this comment.
Thanks for this PR @alvaromontoro! Sorry for the late review over Christmas & New Year. Just a few minor comments 🙂
- Update Warning title - Fix typo - Simplify SASS code
jackdomleo7
approved these changes
Jan 14, 2022
Owner
jackdomleo7
left a comment
jackdomleo7
left a comment
There was a problem hiding this comment.
Thank you for this feature @alvaromontoro!
jackdomleo7
changed the title
jackdomleo7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show warning message if zoom/scale has been disabled via HTML. This new feature includes the following changes:
Why is this important?
Disabling the zoom/scale prevents users from making the page larger and it can be an accessibility problem as they may not be able to read or see the content.
Covered test cases
Added a cypress test case to check if there's a warning if the meta
viewporthas some wrong properties.Did you test on all major browsers?
Other details
Screenshot on Chrome:
T&Cs