Feature/longdesc feature #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leo7#151) These changes address jackdomleo7#108 and jackdomleo7#151. Summary of changes: - Add warning when longdesc is present - Add error when longdesc has some invalid values (empty, containing white spaces, or image urls) - Add examples to the demo page - Add tests for the new warnings and errors - Update the list of codes - Build the library - Switch the order of warnings and errors (jackdomleo7#151)
jackdomleo7
added
a11y feature
This was
linked to
issues
Dec 11, 2021
jackdomleo7
approved these changes
Dec 11, 2021
Owner
jackdomleo7
left a comment
jackdomleo7
left a comment
There was a problem hiding this comment.
Nice one @alvaromontoro, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes address #108 and #151. Summary of changes:
Why is this important?
Longdesc attribute is deprecated and it poses accessibility risks if the value is incorrect (see #108 for more details).
Covered test cases
Tests cases added for:
longdescpresent (only check if it has a border)longdeschas blank spaces or is empty (invalid, if present it should be an URL)longdescpoints to an image URLDid you test on all major browsers?
Other details
This PR also addresses #151
T&Cs