Fix FindMigrations panic with missing migrations #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a migration was missing and the directory contained only valid migration files, FindMigrations would panic with an index out of range error instead of returning an error indicating a missing migration. This was hidden in the tests because the test data included a non-migration file that added an extra element to the array.
bluekeyes
force-pushed
the
fix-find-panic
branch
from
a1ff81e
to
0bc69b7
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a migration was missing and the directory contained only valid migration files,
FindMigrationswould panic with an index out of range error instead of returning an error indicating a missing migration.I think this was missed in #65 because the test data included a non-migration file that added an extra element to the
foundMigrationsslice.