stdlib: Discard connections with open transactions in ResetSession #2481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a connection is returned to the database/sql pool with an open transaction, ResetSession now returns driver.ErrBadConn to discard it. This prevents transaction state from leaking between operations. Previously, if application code failed to commit or rollback a transaction, the connection would be returned to the pool and reused. Subsequent operations would unknowingly execute inside the leaked transaction, and their work would be lost when the connection was eventually discarded. This matches the behavior of pgxpool, which already checks TxStatus when releasing connections and destroys those not in idle state. Signed-off-by: Jeremy Schneider <schneider@ardentperf.com>
Contributor
Author
|
FYI - a reproduction is here https://github.com/ardentperf/pg-idle-test/tree/main/conn_exhaustion I also used that test framework to test this PR Would be good for a second pair of eyes to double-check that I'm adding the line in the right place though. I am pretty new to pgx (and golang in general) |
Owner
|
LGTM. I also added a test that validates correct behavior: 943af21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connection is returned to the database/sql pool with an open
transaction, ResetSession now returns driver.ErrBadConn to discard it.
This prevents transaction state from leaking between operations.
Previously, if application code failed to commit or rollback a
transaction, the connection would be returned to the pool and reused.
Subsequent operations would unknowingly execute inside the leaked
transaction, and their work would be lost when the connection was
eventually discarded.
This matches the behavior of pgxpool, which already checks TxStatus when
releasing connections and destroys those not in idle state.
Signed-off-by: Jeremy Schneider schneider@ardentperf.com