Fix behavior of CollectRows to return empty slice if Rows are empty #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @its-felix and the quick merge @jackc. Will a new tag/release created with this fix? The change in behavior is especially impactful when JSON serializing the response (like in a REST API backend server) since then instead of an empty array you'd get a null value which is unexpected (somehow related to golang/go#37711) |
|
That's also the exact reason why it caught my eye, leading to this PR and why I rolled back to 5.5.2 in my project. |
|
v5.5.4 was just released. |
its-felix
added a commit
to its-felix/pgx
that referenced
this pull request
Mar 5, 2024
its-felix
added a commit
to its-felix/pgx
that referenced
this pull request
Mar 5, 2024
jackc
pushed a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1924