Ensure there is a timeout for background pool connections

jackc · Aug 6, 2022 · 7ce634d · 7ce634d
1 parent f3e04b2
commit 7ce634d
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pgxpool/pool.go b/pgxpool/pool.go
@@ -214,6 +214,10 @@ func ConnectConfig(ctx context.Context, config *Config) (*Pool, error) {
 			// see https://github.com/jackc/pgx/issues/1259
 			ctx = detachedCtx{ctx}
 
+			// But we do want to ensure that a connect won't hang forever.
+			ctx, cancel := context.WithTimeout(ctx, 2*time.Minute)
+			defer cancel()
+
 			connConfig := p.config.ConnConfig
 
 			if p.beforeConnect != nil {