Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize parseNumericString #205

Merged
merged 2 commits into from
Jul 22, 2023
Merged

optimize parseNumericString #205

merged 2 commits into from
Jul 22, 2023

Conversation

horpto
Copy link
Contributor

@horpto horpto commented Jul 18, 2023 

BenchmarkParseNumericString
=== RUN   BenchmarkParseNumericString/ParseNumericString
BenchmarkParseNumericString/ParseNumericString
BenchmarkParseNumericString/ParseNumericString-8                 5844016               212.1 ns/op            88 B/op             4 allocs/op
=== RUN   BenchmarkParseNumericString/ParseNumericStringOld
BenchmarkParseNumericString/ParseNumericStringOld
BenchmarkParseNumericString/ParseNumericStringOld-8              4996562               235.4 ns/op           120 B/op             5 allocs/op
PASS

@jackc
Copy link
Owner

jackc commented Jul 20, 2023

There seem to be some test failures.

@jackc jackc merged commit 0458fa6 into jackc:master Jul 22, 2023
1 check passed
@jackc
Copy link
Owner

jackc commented Jul 22, 2023

👍

@horpto horpto mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horpto @jackc