Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concludeCommand should not throw away fieldDescriptions #36

Merged
merged 2 commits into from
May 13, 2020
Merged

concludeCommand should not throw away fieldDescriptions #36

merged 2 commits into from
May 13, 2020

Conversation

Eun
Copy link
Contributor

@Eun Eun commented Apr 30, 2020 •
edited
Loading

Problem

Getting FieldDescriptions from an empty result set (0 rows) returns a nil slice

Solution

concludeCommand should not clear fieldDescriptions

@jackc jackc merged commit fb54a80 into jackc:master May 13, 2020
@jackc
Copy link
Owner

jackc commented May 13, 2020

Thanks!

@Eun Eun deleted the patch-1 branch May 13, 2020 13:46
This was referenced Jun 28, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eun @jackc