Draft
Conversation
- Renamed all the methods, sometimes altering their name to make them more consistent - Removed deprecated methods - Adapted documentation - The `JackMessageAPI.cpp` currently is just a copy of `JackMidiAPI.cpp`.
It almost completely replaced the midi port type.
`JACK_METADATA_SIGNAL_TYPE` and `JACK_METADATA_EVENT_TYPES` get deprecated in favour of `JACK_METADATA_PORT_CONTENT`.
- It makes no sense to have two different properties, since they can be distinguished based on the port's type. It requires one step more to get the content type of an unknown port.
- Having a port support multiple protocols is not a good idea. It results in input and output ports having a different meaning ("be liberal in what you accept and conservative in what you send"). It makes checking for compatibility between two port way harder for little benefit.
piegamesde
force-pushed
the
osc-support-3
branch
from
46267d2 to
ffa8b85
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I redid some things, cherrypicked some commits and did a few things differently. Tell me which implementation details you prefer.