Merge pull request alibaba#185

optimize size() method to isEmpty()
jack-yu-matrix · Mar 25, 2021 · 14c94b2 · 14c94b2
2 parents 6d6149b + c842718
commit 14c94b2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cola-components/cola-component-dto/src/main/java/com/alibaba/cola/dto/MultiResponse.java b/cola-components/cola-component-dto/src/main/java/com/alibaba/cola/dto/MultiResponse.java
@@ -26,7 +26,7 @@ public void setData(Collection<T> data) {
     }
 
     public boolean isEmpty() {
-        return data == null || data.size() == 0;
+        return data == null || data.isEmpty();
     }
 
     public boolean isNotEmpty() {

diff --git a/cola-components/cola-component-dto/src/main/java/com/alibaba/cola/dto/PageResponse.java b/cola-components/cola-component-dto/src/main/java/com/alibaba/cola/dto/PageResponse.java
@@ -75,7 +75,7 @@ public int getTotalPages() {
     }
 
     public boolean isEmpty() {
-        return data == null || data.size() == 0;
+        return data == null || data.isEmpty();
     }
 
     public boolean isNotEmpty() {

diff --git a/...-components/cola-component-exception/src/main/java/com/alibaba/cola/exception/Assert.java b/...-components/cola-component-exception/src/main/java/com/alibaba/cola/exception/Assert.java
@@ -95,13 +95,13 @@ public static void notNull(Object object) {
     }
 
     public static void notEmpty(Collection<?> collection, String errorCode, String errMessage) {
-        if (collection == null || collection.size() <= 0) {
+        if (collection == null || collection.isEmpty()) {
             throw new BizException(errorCode, errMessage);
         }
     }
 
     public static void notEmpty(Collection<?> collection, String errMessage) {
-        if (collection == null || collection.size() <= 0) {
+        if (collection == null || collection.isEmpty()) {
             throw new BizException(errMessage);
         }
     }