forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pubmatic: Making Adslot param optional (prebid#3788)
* changes for multiformat support * added new constant NATIVE_ASSETS in PubMatic adapter * removed NATIVE_ASSET_KEY reference in PubMatic adapter * removed reference of const NATIVE_ASSET_ID from PubMatic adapter * removed reference of const NATIVE_ASSET_DATA_TYPE in PubMatic adapter * using _commonNativeRequestObject in PubMatic adapter to avoid repeating code block * removed new-lines in const declaration * generating NATIVE_ASSET_REVERSE_ID from NATIVE_ASSETS * renamed NATIVE_ASSET_REVERSE_ID to NATIVE_ASSET_ID_TO_KEY_MAP * little modification in _checkParamDataType in PubMatic adapter * a minor improvement * using let instead of var * added NATIVE_ASSET_KEY_TO_ASSET_MAP and combining switch cases * lint update * removed some stale comments * using LOG_WARN_PREFIX * using const UNDEFINED * added a logWarn in catch * using arrow functions * code review changes * making adSlot parameter optional * added a test case for without adSlot config * changes to checkMediaType function * suppress warning of missing mediaTypes.banner for native and video impression * ignore fluid size, if present, in banner impression * fix for ignoring fluid size in banner impression * added relevant comments and test cases for fluid case in banner request * added sample config for multiformat adunit * commented redundant check * marking adSlot param as optional in examples * fixed some lint errors * removed commnented code * removed a trailing white space * removed a todo comment as suggested in review * deleting commented test cases
- Loading branch information
1 parent
de25c54
commit 61895b0
Showing
3 changed files
with
43 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters