-
Notifications
You must be signed in to change notification settings - Fork 104
Add animation support to material editor for animated materials #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@copilot MaterialPreviewRenderer is the class responsible for showing materials. Suggestion is to: |
Co-authored-by: neph1 <7988802+neph1@users.noreply.github.com>
Co-authored-by: neph1 <7988802+neph1@users.noreply.github.com>
Co-authored-by: neph1 <7988802+neph1@users.noreply.github.com>
…Component Co-authored-by: neph1 <7988802+neph1@users.noreply.github.com>
I've moved the animation toggle from MaterialPreviewWidget to MaterialEditorTopComponent as suggested. The animation checkbox is now located next to the auto-save checkbox in the main editor interface, providing centralized control over animation rendering. Commit 72106a4 addresses this feedback. |
|
@copilot It looks great. One thing; |
Co-authored-by: neph1 <7988802+neph1@users.noreply.github.com>
Good catch! I've added the animationCheckBox to the .form file as well to ensure it persists if someone edits the form visually. The checkbox is now properly defined in both the .form file (with layout, properties, and events) and regenerated in the Java file's generated code section. Commit 22e163a addresses this. |
only allow enqueue once for MaterialPreviewRenderer
|
I pushed to the wrong remote, and approved before I noticed. |
|
I think this is done. Unless someone objects, I'll merge this within a couple of days. |
Implementation Updated - Form File Support ✅
Addressed @neph1's feedback about adding the animationCheckBox to the .form file to ensure it persists if someone edits the form visually in NetBeans.
Key Changes:
MaterialEditorTopComponent.form
MaterialEditorTopComponent.java
The animation checkbox is now properly integrated into the NetBeans form system and will not be lost if someone edits the form visually. The control remains in the main MaterialEditorTopComponent interface next to the auto-save checkbox.
Fixes #667.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.