Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes_#336_Default_values_from_MatDef #391

Merged

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Oct 7, 2022

Fixes #336 Some noise here due to me removing some warnings and formatting the file. Check the comment for the change that matters.
It actually changes the "source" as well. But I guess that is more in line with WYSIWYG, after all.

materialParameters.put(prop.getName(), prop);
}
// property with set value
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the functional change of this PR.

@neph1 neph1 changed the title fixes issue, removes warnings and format Fixes_#336_Default_values_from_MatDef Oct 7, 2022
@tonihele tonihele self-requested a review October 7, 2022 06:59
@neph1 neph1 merged commit 3fee983 into jMonkeyEngine:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default values from MatDef (at least with Shader Nodes) doesn't propagate to material
2 participants