JSON file abstraction improvements#2344
JSON file abstraction improvements#2344JNightRider wants to merge 1 commit intojMonkeyEngine:masterfrom
Conversation
|
Hi @JNightRider, This module is very sensitive and is a critical component, as it is jME's only standard tool for loading glTF models. The splitting of the modules was driven by the effort to bring jMonkeyEngine to the Browser with WebGL2 and TeaVM . While I appreciate your efforts, I would advise against further risky micro-optimizations to this module. Any changes you introduce should be compatible with the Browser API, which is the main reason we are in this situation. I understand it can be frustrating when proposed changes aren't accepted. My intention is to encourage your enthusiasm, not discourage it. If another maintainer reviews your PR and deems it low-risk, we can proceed. Otherwise, I suggest closing it. |
|
Hi @capdevon
In the case of the generic class I think it is an improvement since we do not have to do a "Casting" when using the elements of said objects, as for the wrappers, it is for I don't really think it makes the API more complicated, it simplifies it a bit more (when reading the code) and these changes apply more to the default
I completely agree with you, this issue needs to be addressed carefully to avoid bugs in future versions.
I would like to clarify this topic, the As for the
For now I will keep it open (possibly close it if the risk remains high). Thanks for reviewing this PR 👍. |
Hello everyone.
This PR improves the abstraction of JSON objects (files), as it is currently very limited and if there are null values it is very difficult (cumbersome) to deal with as it does not provide mechanisms to identify it.
Also in this PR topic #2316 (implementation of method to identify the type of element) is addressed, since this topic is closely linked to the objective of this PR (which is to improve said abstraction) and is included in it,
At the moment, as far as I know, these changes don't break anything (especially the GLTF loader, in my tests everything works)
What do you think of these changes?