resolve issue #1958 (jmf library coming with j-ogg-all is not required)#1959
Closed
Ali-RS wants to merge 1 commit intojMonkeyEngine:masterfrom
Closed
resolve issue #1958 (jmf library coming with j-ogg-all is not required)#1959Ali-RS wants to merge 1 commit intojMonkeyEngine:masterfrom
Ali-RS wants to merge 1 commit intojMonkeyEngine:masterfrom
Conversation
…r decoding ogg files.
Member
|
I plan to release a new library "j-ogg-vorbis" which will be like "j-ogg-all" but will exclude the flac and Theora decoders. It won't depend on JMF. That will make this PR redundant, so perhaps you should hold off on this... |
Member
Author
|
Ok, no problem. I will discard this PR then and will submit a new one that makes use of Thanks |
Member
Author
|
Closing this for #1962 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR excludes
javax.media:jmflibrary fromjme3-joggmodule as it is not required for decoding ogg files in JME.Fix issue #1958