Squash build races between dmalloc.h and .o files #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the object code to depend on dmalloc.h as it's generated over the course of the build. This unbreaks parallel builds (-j greater than 1). NB: technically all of the local header dependencies should be fully mapped to their .o files to ensure that the .o files are properly rebuilt when the headers are modified, but this covers the core concurrent build issue that was occurring prior to this change. Closes: j256#119 Co-authored-by: Bryan Drewery <bdrewery@FreeBSD.org> Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the object code to depend on dmalloc.h as it's generated over the course of the build. This unbreaks parallel builds (-j greater than 1).
NB: technically all of the local header dependencies should be fully mapped to their .o files to ensure that the .o files are properly rebuilt when the headers are modified, but this covers the core concurrent build issue that was occurring prior to this change.
Closes: #119