-
-
Notifications
You must be signed in to change notification settings - Fork 104
Fix docker tags #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker tags #1257
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1257 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 80 80
Lines 15627 15627
=======================================
Hits 14069 14069
Misses 1558 1558 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects the docker tag type from pep440 (Python versioning) to semver (semantic versioning), which is appropriate for this Rust project that uses semantic versioning (0.2.23).
Key changes:
- Converted docker metadata-action tag types from
pep440tosemverformat - Updated tag patterns to use semver-compatible syntax
- Removed one full version tag pattern in the docker-publish job
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| images: ${{ env.PREK_BASE_IMG }} | ||
| # Order is on purpose such that the label org.opencontainers.image.version has the first pattern with the full version | ||
| tags: | |
Copilot
AI
Dec 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the full version tag pattern creates an inconsistency in docker tagging. The docker-publish job previously had three tag patterns:
- Full version tag (e.g., "0.2.23" or "v0.2.23")
- Raw value tag (same as announcement_tag)
- Major.minor tag (e.g., "0.2" or "v0.2")
After this change, only patterns 2 and 3 remain. While line 137 provides a raw value tag, there's no longer a semver-formatted full version tag that would ensure proper versioning semantics are applied. Consider adding back a full version tag pattern like type=semver,pattern={{ version }},value=${{ fromJson(inputs.plan).announcement_tag }} before the raw value tag to maintain the comment's intent: "Order is on purpose such that the label org.opencontainers.image.version has the first pattern with the full version".
| tags: | | |
| tags: | | |
| type=semver,pattern={{ version }},value=${{ fromJson(inputs.plan).announcement_tag }} |
| type=pep440,pattern={{ version }},value=${{ fromJson(inputs.plan).announcement_tag }} | ||
| type=raw,value=${{ fromJson(inputs.plan).announcement_tag }} | ||
| type=pep440,pattern={{ major }}.{{ minor }},value=${{ fromJson(inputs.plan).announcement_tag }} | ||
| type=semver,pattern=v{{ major }}.{{ minor }},value=${{ fromJson(inputs.plan).announcement_tag }} |
Copilot
AI
Dec 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern v{{ major }}.{{ minor }} hardcodes the "v" prefix. This assumes the announcement_tag value includes the "v" prefix (e.g., "v0.2.23"). If the announcement_tag is provided without the prefix, this will fail to parse as a valid semver. Consider using {{ major }}.{{ minor }} without the "v" prefix for consistency with standard semver tagging practices, or ensure that the input validation explicitly requires the "v" prefix in announcement_tag.
| type=semver,pattern=v{{ major }}.{{ minor }},value=${{ fromJson(inputs.plan).announcement_tag }} | |
| type=semver,pattern={{ major }}.{{ minor }},value=${{ fromJson(inputs.plan).announcement_tag }} |
📦 Cargo Bloat ComparisonBinary size change: +0.00% (16.7 MiB → 16.7 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
No description provided.