Remove panic from Options::positionals and add Options::no_value

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "getargs"
-version = "0.5.0"
+version = "0.6.0"
 authors = ["Jasmine Tai <jtai@jtai.ca>", "LoganDark"]
 edition = "2021"
 license = "MIT"

examples/complete.rs

@@ -60,7 +60,7 @@ fn parse_args<'a, I: Iterator<Item = &'a str>>(
     }
 
     let subcommand_name = opts
-        .next_positional()
+        .next_positional()?
         .ok_or(UsageError::MissingSubcommand)?;
     let subcommand = match subcommand_name {
         "c" | "create" => parse_create_args(opts)?,
@@ -86,7 +86,7 @@ fn parse_create_args<'a, I: Iterator<Item = &'a str>>(
         }
     }
 
-    let args = opts.positionals().collect();
+    let args = opts.positionals()?.collect();
     Ok(Subcommand::Create { output, args })
 }
 
@@ -104,7 +104,7 @@ fn parse_delete_args<'a, I: Iterator<Item = &'a str>>(
         }
     }
 
-    let args = opts.positionals().collect();
+    let args = opts.positionals()?.collect();
     Ok(Subcommand::Delete { backup, args })
 }
 

examples/no_alloc.rs

@@ -23,7 +23,7 @@ fn main() {
         }
     }
 
-    for positional in opts.positionals() {
+    for positional in opts.positionals().expect("calling Options::positionals") {
         eprintln!("positional argument: {}", positional);
     }
 }

examples/print.rs

@@ -40,7 +40,7 @@ optional value.
         }
     }
 
-    for arg in opts.positionals() {
+    for arg in opts.positionals().unwrap() {
         eprintln!("positional: {:?}", arg)
     }
 }

examples/subcommands.rs

@@ -15,7 +15,7 @@ fn parse<'arg, I: Iterator<Item = &'arg str>>(
         println!("option for base command: {opt}");
     }
 
-    let subcommand = opts.next_positional();
+    let subcommand = opts.next_positional()?;
     println!("subcommand: {subcommand:?}");
     match subcommand {
         None => println!("no subcommand"),
@@ -35,7 +35,7 @@ fn parse_run<'arg, I: Iterator<Item = &'arg str>>(
             _ => println!("'run' subcommand got unknown option {opt:?}"),
         }
     }
-    for pos in opts.positionals() {
+    for pos in opts.positionals()? {
         println!("positional arg: {pos}");
     }
     Ok(())
@@ -53,7 +53,7 @@ fn parse_test<'arg, I: Iterator<Item = &'arg str>>(
             _ => println!("'test' subcommand got unknown option {opt:?}"),
         }
     }
-    for pos in opts.positionals() {
+    for pos in opts.positionals()? {
         println!("positional arg: {pos}");
     }
     Ok(())

src/error.rs

@@ -36,14 +36,14 @@ pub enum Error<A: Argument> {
     /// [`Options::next_opt`][crate::Options::next_opt] or
     /// [`Options::next_arg`][crate::Options::next_arg] is called
     /// without the value being consumed.
-    DoesNotRequireValue(Opt<A>),
+    RequiresNoValue(Opt<A>),
 }
 
 impl<'arg, S: Display, A: Argument<ShortOpt = S> + Display + 'arg> Display for Error<A> {
     fn fmt(&self, f: &mut Formatter) -> core::fmt::Result {
         match self {
             Error::RequiresValue(opt) => write!(f, "option requires a value: {}", opt),
-            Error::DoesNotRequireValue(opt) => {
+            Error::RequiresNoValue(opt) => {
                 write!(f, "option does not require a value: {}", opt)
             }
         }

src/iter.rs

@@ -18,7 +18,7 @@ impl<'opts, A: Argument, I: Iterator<Item = A>> Iterator for Positionals<'opts,
     type Item = A;
 
     fn next(&mut self) -> Option<Self::Item> {
-        self.inner.next_positional()
+        self.inner.next_positional().unwrap()
     }
 }