readme: fixes spelling #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haha those are the kind of typos your brain autocorrects when reading :D Never noticed them. Thanks a lot! Now if you'd remove the s at the end of addSubtitles and removeSubtitles again to make it consistent with the documentation I'll happily merge it (And fix the title in Version2 where it probably exists as well). Thanks a lot for the contribution! |
|
Sorry for some reason I thought you fixed the spelling in the JavaScript file but you made the readme consistent to what is actually in the code. Sorry :) I guess I'll have to change selectSubtitle to selectSubtitles to make it consistent ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some
_subtitle.jsrelated calls were misspelled in the readme.