Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme #12

Merged
merged 4 commits into from
Feb 14, 2017
Merged

update readme #12

merged 4 commits into from
Feb 14, 2017

Conversation

pussinboot
Copy link
Contributor

as discussed in #11
plus some minor changes including grammar fixes and changing from the word "song" to "file"

@j-holub
Copy link
Owner

j-holub commented Feb 12, 2017

Thank. I like your *Known Issues text. Sounds good plus it's nice and clean.

Thank you as well for fixing my English :D I do think my English is rather good but I still make mistakes I guess. I'm not a native.

The reason it took me 2 days to reply was that I had to think about the observing part. I actually wanted that section about Observing where all the information was in one place. But with the events right above it, it does indeed seem redundant. After reading your version a couple of times and comparing it to the present one, I'd say I like it. Thanks!

I'm not sure about the file terminology however. I indeed wrote song sometimes and it can also be a video, so this has to be fixed, I agree.
But mpv can also load a stream from YouTube, SoundCloud and many other sources (I assume it downloads it through youtube-dl anyway), that's why I think file is not the correct word either. I think I'd just like to keep the terminology to title, like I used it in some places in the README file.

@pussinboot
Copy link
Contributor Author

hey, no worries about the response time.
you're right title is a better term, i've fixed this (i think) with the latest commit. when it can be either a file or a stream i've used the word "title," for loadFile, which only works for local files the word "file" is used. let me know if i missed any, but the readme should be more clear overall now

@j-holub
Copy link
Owner

j-holub commented Feb 14, 2017

That looks perfect. Thank you very much for your help :)

Exams are coming up for me, so I don't know how fast I can get the IPC Thing done, but I'm trying to do my best.

@j-holub j-holub merged commit 9e26959 into j-holub:master Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants