Issue #391 - Adding nullability specifiers to NBPhoneNumberUtil functions #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions * Address analyzer warnings related to passing nil to non-nil parameters * Fix build failure with 'ShortNumber' test target
FONickReichard
approved these changes
Mar 12, 2024
|
@iziz - Saw you pulled in a few PRs over the weekend... Any chance this could make the list for another round? 😄 (just trying to eliminate warnings that are showing up when running the Xcode analyzer) |
|
@iziz - Just following up to see about pulling in some PRs (hopefully this one included?!?), and also maybe update the minimum OS versions for cocoapods (so it can build successfully on Xcode 15+) |
|
@iziz - any chance of getting this pulled in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address analyzer warnings related to passing nil to non-nil parameters
Fix build failure with 'ShortNumber' test target