perf(table): remove ExpandIcon

iyuohz · Dec 1, 2021 · cb1759b · cb1759b
1 parent 81560fd
commit cb1759b
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 78 deletions.
diff --git a/build/vite/optimizer.ts b/build/vite/optimizer.ts
diff --git a/build/vite/plugin/hmr.ts b/build/vite/plugin/hmr.ts
diff --git a/src/components/Table/src/BasicTable.vue b/src/components/Table/src/BasicTable.vue
@@ -43,7 +43,6 @@
   import { Table } from 'ant-design-vue';
   import { BasicForm, useForm } from '/@/components/Form/index';
   import { PageWrapperFixedHeightKey } from '/@/components/Page';
-  import expandIcon from './components/ExpandIcon';
   import HeaderCell from './components/HeaderCell.vue';
   import { InnerHandlers } from './types/table';
 
@@ -222,10 +221,8 @@
       const getBindValues = computed(() => {
         const dataSource = unref(getDataSourceRef);
         let propsData: Recordable = {
-          // ...(dataSource.length === 0 ? { getPopupContainer: () => document.body } : {}),
           ...attrs,
           customRow,
-          expandIcon: slots.expandIcon ? null : expandIcon(),
           ...unref(getProps),
           ...unref(getHeaderProps),
           scroll: unref(getScrollRef),

diff --git a/src/components/Table/src/components/ExpandIcon.tsx b/src/components/Table/src/components/ExpandIcon.tsx
diff --git a/src/components/Table/src/hooks/useRowSelection.ts b/src/components/Table/src/hooks/useRowSelection.ts
@@ -21,11 +21,8 @@ export function useRowSelection(
 
     return {
       selectedRowKeys: unref(selectedRowKeysRef),
-      hideDefaultSelections: false,
       onChange: (selectedRowKeys: string[]) => {
         setSelectedRowKeys(selectedRowKeys);
-        // selectedRowKeysRef.value = selectedRowKeys;
-        // selectedRowRef.value = selectedRows;
       },
       ...omit(rowSelection, ['onChange']),
     };

diff --git a/src/components/Table/src/props.ts b/src/components/Table/src/props.ts
@@ -10,6 +10,7 @@ import type {
   SizeType,
 } from './types/table';
 import type { FormProps } from '/@/components/Form';
+
 import { DEFAULT_FILTER_FN, DEFAULT_SORT_FN, FETCH_SETTING, DEFAULT_SIZE } from './const';
 import { propTypes } from '/@/utils/propTypes';
 

diff --git a/src/components/Tree/src/Tree.vue b/src/components/Tree/src/Tree.vue
@@ -13,6 +13,7 @@
     watch,
     onMounted,
   } from 'vue';
+  import TreeHeader from './TreeHeader.vue';
   import { Tree, Empty } from 'ant-design-vue';
   import { TreeIcon } from './TreeIcon';
   import { ScrollContainer } from '/@/components/Container';
@@ -23,7 +24,6 @@
   import { useTree } from './useTree';
   import { useContextMenu } from '/@/hooks/web/useContextMenu';
   import { CreateContextOptions } from '/@/components/ContextMenu';
-  import TreeHeader from './TreeHeader.vue';
   import { treeEmits, treeProps } from './tree';
   import { createBEM } from '/@/utils/bem';
 

diff --git a/src/components/Tree/src/TreeHeader.vue b/src/components/Tree/src/TreeHeader.vue
@@ -5,7 +5,7 @@
       {{ title }}
     </BasicTitle>
     <div
-      class="flex flex-1 justify-self-stretch items-center cursor-pointer"
+      class="flex items-center flex-1 cursor-pointer justify-self-stretch"
       v-if="search || toolbar"
     >
       <div :class="getInputSearchCls" v-if="search">
@@ -46,7 +46,6 @@
 
   const [bem] = createBEM('tree-header');
 
-  // eslint-disable vue/valid-define-emits
   const props = defineProps({
     helpMessage: {
       type: [String, Array] as PropType<string | string[]>,