- bugfix {$smarty.section...} used outside {section}{/section} showed…

… incorrect values if {section}{/section} was called inside another loop smarty-php#422
iyifei · Mar 21, 2018 · b7e7def · b7e7def
1 parent 60415e6
commit b7e7def
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/change_log.txt b/change_log.txt
@@ -1,4 +1,8 @@
 ===== 3.1.32 - dev ===
+21.03.2018
+ - bugfix {$smarty.section...} used outside {section}{/section} showed incorrect values if {section}{/section} was called inside
+   another loop https://github.com/smarty-php/smarty/issues/422
+
 17.03.2018
  - improvement Smarty::compileAllTemplates() exit with a non-zero status code if max errors is reached https://github.com/smarty-php/smarty/pull/402
 

diff --git a/libs/Smarty.class.php b/libs/Smarty.class.php
@@ -112,7 +112,7 @@ class Smarty extends Smarty_Internal_TemplateBase
     /**
      * smarty version
      */
-    const SMARTY_VERSION = '3.1.32-dev-40';
+    const SMARTY_VERSION = '3.1.32-dev-41';
     /**
      * define variable scopes
      */

diff --git a/libs/sysplugins/smarty_internal_compile_section.php b/libs/sysplugins/smarty_internal_compile_section.php
@@ -104,8 +104,7 @@ public function compile($args, Smarty_Internal_TemplateCompilerBase $compiler)
         // maybe nocache because of nocache variables
         $compiler->nocache = $compiler->nocache | $compiler->tag_nocache;
 
-        $initLocal =
-            array('saved' => "isset(\$_smarty_tpl->tpl_vars['__smarty_section_{$attributes['name']}']) ? \$_smarty_tpl->tpl_vars['__smarty_section_{$attributes['name']}'] : false",);
+        $initLocal = array();
         $initNamedProperty = array();
         $initFor = array();
         $incFor = array();
@@ -455,9 +454,6 @@ public function compile($args, Smarty_Internal_TemplateCompilerBase $compiler)
         } else {
             $output .= "}\n}\n";
         }
-        $output .= "if ({$local}saved) {\n";
-        $output .= "{$sectionVar} = {$local}saved;\n";
-        $output .= "}\n";
         $output .= '?>';
 
         return $output;