#14 #15 Serialize EDTFField values into DB #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve performance of EDTFField when populating model instances from DB values by storing EDTF data in pickled format, not as string values that need to be re-parsed every time they are loaded. This implementation is naive and could be improved with a more sophisticated serialization approach for EDTF fields, though it works for now. This change also handles the issue in #15 where already- parsed EDTF field values are re-parsed when an instance is saved, unless there is a `natural_text_field` value present to override and reset the EDTF field value.
Bump the character field size up to 2000 to avoid hitting character limits with this temporary fix, until we have a better serialization mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of EDTFField when populating model
instances from DB values by storing EDTF data in pickled
format, not as string values that need to be re-parsed
every time they are loaded. See #14
This implementation is naive and could be improved with
a more sophisticated serialization approach for EDTF
fields, though it works for now.
This change also handles the issue in #15 where already-
parsed EDTF field values are re-parsed when an instance
is saved, unless there is a
natural_text_fieldvaluepresent to override and reset the EDTF field value.