fix(download): restore password verification #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rackover
requested changes
Jan 20, 2024
src/Components/Modules/Download.cpp
Outdated
| char buffer[128]{}; | ||
| const auto len = mg_http_get_var(&hm->query, "password", buffer, sizeof(buffer)); | ||
|
|
||
| const auto reply = [&c](const char* s) -> void |
There was a problem hiding this comment.
Instead of rewritting it here as a local, could you please use ReplyError() function instead, and modify ReplyError to accept a custom optional message if you want to send a specific string?
Rackover
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old feature by momo, his old code didn't work because he forgot to to call dump hex on the server password.
I removed it during the great refactoring of download.cpp when we upgraded past 4 major releases of mongoose.
Now I add it back