Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation functions Fixup #1952

Merged
merged 21 commits into from
Jul 25, 2022
Merged

Creation functions Fixup #1952

merged 21 commits into from
Jul 25, 2022

Conversation

iamjameskeane
Copy link
Contributor

Edits to:
Type hints on all Creation Backends
Small fixes to Unit tests
Small fix to asarray() docstring

@iamjameskeane
Copy link
Contributor Author

@Auxia If you take a quick look over changes and make sure you are happy before we request a review 😀

@iamjameskeane iamjameskeane requested a review from djl11 July 15, 2022 10:07
Copy link
Contributor

@djl11 djl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add # for review at the top of every file which is being reviewed, so that I can leave file-specific comments.

Aside from the comment I left, I also noticed that linspace and logspace are only testing for a fixed size array. Could you further diversify the shapes of the start and stop arrays in these tests?

Once done, please request another review, thanks!

@iamjameskeane
Copy link
Contributor Author

iamjameskeane commented Jul 22, 2022

Issues currently with unit tests not passing for torch backend due to changes to device, from_dlpack also not passing.

@iamjameskeane iamjameskeane requested a review from djl11 July 22, 2022 15:04
Copy link
Contributor

@djl11 djl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from these small changes, I think it's good. I would say get this merged once these changes have been made, and then you can get the few tests passing afterwards :)

@iamjameskeane iamjameskeane merged commit 1d1ec73 into master Jul 25, 2022
@iamjameskeane iamjameskeane deleted the creation-functions-fixup branch July 28, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants