-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation functions Fixup #1952
Creation functions Fixup #1952
Conversation
@Auxia If you take a quick look over changes and make sure you are happy before we request a review 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add # for review
at the top of every file which is being reviewed, so that I can leave file-specific comments.
Aside from the comment I left, I also noticed that linspace
and logspace
are only testing for a fixed size array. Could you further diversify the shapes of the start and stop arrays in these tests?
Once done, please request another review, thanks!
Issues currently with unit tests not passing for torch backend due to changes to device, from_dlpack also not passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from these small changes, I think it's good. I would say get this merged once these changes have been made, and then you can get the few tests passing afterwards :)
Edits to:
Type hints on all Creation Backends
Small fixes to Unit tests
Small fix to asarray() docstring