Skip to content

Conversation

nadjib
Copy link
Contributor

@nadjib nadjib commented Aug 22, 2017

For fix bug replace original image

For fix bug replace original image
@ivpusic
Copy link
Owner

ivpusic commented Aug 23, 2017

hmm...what if for some reason filename does not contain dot? in that case user would get IndexOutOfBoundsException. Could you update your code to handle this?

@nadjib nadjib changed the title Create another file for compressed picture Create another file for compressed picture with different name Aug 23, 2017
@nadjib
Copy link
Contributor Author

nadjib commented Aug 23, 2017

ok, I settled that.

@nadjib
Copy link
Contributor Author

nadjib commented Aug 23, 2017

This is important, because without this correction the image captured by camera will be saved in Environment.DIRECTORY_PICTURES, and in this same location the compressed image will be saved. Its causes an error because the original image will be opened (opened resource) and the code will try to write the compressed image in this opened resource (Overwriting problem).

@ivpusic ivpusic merged commit 204f20b into ivpusic:master Aug 23, 2017
@ivpusic
Copy link
Owner

ivpusic commented Aug 23, 2017

thanks

@nadjib
Copy link
Contributor Author

nadjib commented Aug 23, 2017

@ivpusic can you create a new tag for this last commit ? I want to set version number in my package.json file.

@ivpusic
Copy link
Owner

ivpusic commented Aug 23, 2017

try https://github.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.15.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants