Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example project #2097

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Conversation

sean5940
Copy link
Contributor

@sean5940 sean5940 commented Oct 8, 2024

I upgraded the example project from version 0.64.2 to 0.73.8 using the React Native Upgrade Helper.

I have verified that the project is functioning correctly on simulators for both iOS and Android.

Now it’s easier to track changes in the library. 🥳

Android IOS

@sean5940
Copy link
Contributor Author

sean5940 commented Oct 8, 2024

@ivpusic Could you help take a look?

@ivpusic ivpusic merged commit 1798118 into ivpusic:master Oct 8, 2024
@ivpusic
Copy link
Owner

ivpusic commented Oct 8, 2024

thanks!

@@ -6,7 +6,8 @@
</intent>
</queries>

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is causing the User did not grant library permission that some people is having on android devices. @ivpusic @sean5940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants