[iOS] Fix compression resize resulting in blank image #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markholland
changed the title
|
Hey Mark! Thanks for submitting your solution. There's a small tweak that I noticed - you need to pass the created That way it works for me. |
ios/src/Compression.m
Outdated
| @@ -53,6 +53,8 @@ - (ImageResult*) compressImageDimensions:(UIImage*)image | |||
| } | |||
| CGSize newSize = CGSizeMake(newWidth, newHeight); | |||
|
|
|||
| UIGraphicsImageRendererFormat *format = [UIGraphicsImageRendererFormat new]; | |||
| format.scale = 1; | |||
| UIGraphicsImageRenderer *renderer = [[UIGraphicsImageRenderer alloc] initWithSize:newSize]; | |||
There was a problem hiding this comment.
Suggested change
| UIGraphicsImageRenderer *renderer = [[UIGraphicsImageRenderer alloc] initWithSize:newSize]; | |
| UIGraphicsImageRenderer *renderer = [[UIGraphicsImageRenderer alloc] initWithSize:newSize format:format]; |
There was a problem hiding this comment.
Thanks, must have been asleep at the wheel that day. Glad it helped you.
markholland
force-pushed
the
fix-compression
branch
from
a9577dc
to
fe298cf
Compare
|
Is this going to be merged soon ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2074