-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed camera permission on Android since it is not required #1974
base: master
Are you sure you want to change the base?
Conversation
Interesting, do you have a source where it is explained? Did you test it by reinstalling the app? |
Source: https://developer.android.com/guide/topics/media/camera#manifest Tested on: Android 13 (device), 11 (simulator), 9 (simulator) and 8.1 (device) |
Thanks for the source. Sounds good! |
Could someone test this? |
I'm using in production without issues so far |
@RodolfoGS I just sounds to good to be true :) |
Try it yourself, just remove the permission from the code and you will see that the camera app is opened and works perfect. Also, you could try with react-native-image-picker that also do not use the camera permission.
Source: https://github.com/react-native-image-picker/react-native-image-picker#android-1 |
@ivpusic Could you check? |
Manifest.permission.CAMERA is not required to open the camera and take a picture. So, it could be removed to avoid requesting it to the user.
Also, you need to remove this line from your
app/src/main/AndroidManifest.xml