Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for openPicker not working when app targets Android 13 #1852

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

dtumonasingh
Copy link
Contributor

* Fix for openPicker not working when app targets Android 13 on Android 13 device

Note: Developers must also add the READ_MEDIA_IMAGES images permission in their manifest files.

Essential Links to understand the PR change

Android 13 documentation on the new granular permissions : https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions

Bug raised on Google which confirms we need READ_MEDIA_IMAGES for Android 13 and above instead of WRITE_EXTERNAL_STORAGE - https://issuetracker.google.com/issues/237634019

Issue created against this fix on github - #1849

@Froncz
Copy link

Froncz commented Nov 11, 2022

Hey, when is there a chance to merge this one? I believe the sooner the better because Android 13 will become increasingly popular daily.

@Arkan4ik
Copy link

need to support android 13. how is it going?

@dtumonasingh
Copy link
Contributor Author

Is there anything I need to do here? Like add reviewers?

@ivpusic ivpusic merged commit 34b0769 into ivpusic:master Dec 14, 2022
@ivpusic
Copy link
Owner

ivpusic commented Dec 14, 2022

thanks!

@kaisv7n
Copy link

kaisv7n commented Jan 7, 2023

Screen Shot 2023-01-07 at 12 36 10

Hi, How can I fix this one? I can't run android on version 0.39.0

@pnthach95
Copy link
Contributor

Hi, How can I fix this one? I can't run android on version 0.39.0

Change SDK version to 33, read my PR about it #1887

@rililive
Copy link

Need to update the README as well. This is also a breaking change

fmorau pushed a commit to sharekey/react-native-image-crop-picker that referenced this pull request Feb 24, 2023
joshuatam added a commit to joshuatam/react-native-image-crop-picker that referenced this pull request Mar 8, 2023
@ayoubshah2720
Copy link

ayoubshah2720 commented Jul 26, 2023

Added these permissions works for me for Android 13

image

@RodolfoGS
Copy link
Contributor

I do not recommend to use the READ_MEDIA_IMAGES permission.

Note: If your app only needs to access images, photos, and videos, consider using the photo picker instead of declaring the READ_MEDIA_IMAGES and READ_MEDIA_VIDEO permissions.

Source: https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions

PR #1973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants