Make list items accessible #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that one of the views for selecting images was not accessible and would like to make it accessible. This was based on user feedback.
|
This is great! Currently the user is not able to select any photos in accessibility mode (VoiceOver), we need this! :) |
|
You saved my day, @v-miibr |
|
You should also add: This will make it clear that it's an image that can be selected, and iOS will even sometimes be able to detect the contents of the image and read a description...super cool. I'm using this patch and it's been working great. Should definitely be merged in with my suggested change! |
|
Any update on when will be this change available in the package? |
|
This would be super helpful for a lot of people, please consider merging this! |
Nanjundan
approved these changes
Jan 20, 2024
|
Hello @ivpusic Can you consider merging this PR with AccessibilityTraits? |
renovate bot
referenced
this pull request
in valora-inc/wallet
Feb 17, 2024
#4932) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-image-crop-picker](https://togithub.com/ivpusic/react-native-image-crop-picker) | [`^0.40.2` -> `^0.40.3`](https://renovatebot.com/diffs/npm/react-native-image-crop-picker/0.40.2/0.40.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ivpusic/react-native-image-crop-picker (react-native-image-crop-picker)</summary> ### [`v0.40.3`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.40.3) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.40.2...v0.40.3) #### What's Changed - Make list items accessible by [@​v-miibr](https://togithub.com/v-miibr) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1439](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1439) #### New Contributors - [@​v-miibr](https://togithub.com/v-miibr) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1439](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1439) **Full Changelog**: ivpusic/react-native-image-crop-picker@v0.40.2...v0.40.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
shottah
referenced
this pull request
in zed-io/kolektivo
May 15, 2024
valora-inc#4932) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-image-crop-picker](https://togithub.com/ivpusic/react-native-image-crop-picker) | [`^0.40.2` -> `^0.40.3`](https://renovatebot.com/diffs/npm/react-native-image-crop-picker/0.40.2/0.40.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ivpusic/react-native-image-crop-picker (react-native-image-crop-picker)</summary> ### [`v0.40.3`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.40.3) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.40.2...v0.40.3) #### What's Changed - Make list items accessible by [@​v-miibr](https://togithub.com/v-miibr) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1439](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1439) #### New Contributors - [@​v-miibr](https://togithub.com/v-miibr) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1439](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1439) **Full Changelog**: ivpusic/react-native-image-crop-picker@v0.40.2...v0.40.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that one of the views for selecting images was not accessible and would like to make it accessible. This was based on user feedback.