Skip to content

Updating role diagram to use ivoatex/SVG #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2020

Conversation

msdemlei
Copy link
Contributor

@msdemlei msdemlei commented May 6, 2020

This basically reflects what the old role diagram said, except I've taken out
all the standards that never came to be, and I've added VTP.

Followup changes should probably made to the section on the relationship
to the other standards, but I'm too far removed from VOEvent to dare doing
this.

This basically reflects what the old role diagram said, except I've taken out
all the standards that never came to be, and I've added VTP.

Followup changes should probably made to the section on the relationship
to the other standards, but I'm too far removed from VOEvent to dare doing
this.
@BaptisteCecconi
Copy link
Collaborator

Didi you check PR #2 ? I updated the role diagram too.

@Zarquan
Copy link
Member

Zarquan commented May 22, 2020

Didi you check PR #2 ? I updated the role diagram too.

I merged PR #2, so is this needed now ?

Copy link
Collaborator

@BaptisteCecconi BaptisteCecconi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of role_diagram.xml is missing VOUnits and the current WD is missing Vocabularies. If the merge process goes well it's fine, it should be ok.

@BaptisteCecconi
Copy link
Collaborator

I've fixed the merge conflicts in role_diagram.xml

@BaptisteCecconi
Copy link
Collaborator

@Zarquan can you check and eventually approve ?

@BaptisteCecconi BaptisteCecconi mentioned this pull request May 27, 2020
Copy link
Member

@Zarquan Zarquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good.

@Zarquan Zarquan merged commit 589b0c4 into ivoa-std:master May 28, 2020
BaptisteCecconi added a commit that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants