Skip to content

Time instant/epoch #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: wd-v1.0
Choose a base branch
from
Open

Time instant/epoch #87

wants to merge 25 commits into from

Conversation

lmichel
Copy link
Collaborator

@lmichel lmichel commented Apr 18, 2025

  • New datatype (Epoch(representation, value) for the timestamps
  • No more PhotometricProperty abstract class

@loumir
Copy link
Collaborator

loumir commented Apr 22, 2025

The update of the 2 diagrams sounds good me.

@loumir loumir self-requested a review April 22, 2025 09:32
@loumir
Copy link
Collaborator

loumir commented Apr 22, 2025 •
edited
Loading

in the documentation generated for EPOCH type , the description strings are missing .

<dataType>
     <vodml-id>Epoch</vodml-id>
     <name>Epoch</name>
     <description>
           TODO : Missing description : please, update your UML model asap.   etc....

@lmichel
Copy link
Collaborator Author

lmichel commented Apr 22, 2025

The VODML with descriptions is in vo-dml.
Description elements are edited in specific files

/desc.mango.vo-dml.xml

@loumir
Copy link
Collaborator

loumir commented Apr 22, 2025

found on typo in /desc.mango.vo-dml.xml
on line 114 : "usually an instance of \texttt{mango:EpcohPosition}."
sourd be "usually an instance of \texttt{mango:EpochPosition}."

@lmichel
Copy link
Collaborator Author

lmichel commented May 4, 2025

The PR branch has been updated taking the comment into account and Epoch data type has been renamed as DateTime and EpochPosition.epoch renamed as EpochPosition.obsDate

loumir
loumir reviewed May 5, 2025
View reviewed changes
mivot/mango/mango.Color.xml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

difficult to interpret the change here . I suppose it is OK .

@loumir
Update desc.DateTime.txt - typo
2ceddbc 
Datatype --> Data type
loumir
loumir reviewed May 5, 2025
View reviewed changes
vo-dml/mango.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear in this diagram wether DateTime (with representation) is a class ( greenBlue) or a type (light yellow)

loumir added 2 commits May 5, 2025 12:42
@loumir
Update desc.epoch.InstantTime.txt typo
ceb43d3 
datatype --> data type
@loumir
Update desc.epoch.Seconds.date.txt
ccec742 
ambiguous ' Second date ' ....
loumir
loumir approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator

@loumir loumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes . This clarifies Time related information in the EpochPosition Class as presented in issue #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loumir loumir loumir approved these changes

Assignees

@mcdittmar mcdittmar

@loumir loumir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmichel @loumir @mcdittmar