Skip to content

Commit

Permalink
update reqs and remove ability to alter onLoad events
Browse files Browse the repository at this point in the history
  • Loading branch information
Kyle Milloy committed Mar 21, 2017
1 parent 0c686f5 commit aaa09de
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 14 deletions.
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
## 1.2.0 (20-03-2017)

[#14](https://github.com/itsnubix/react-native-video-controls/issues/14)
- Remove ability for loading events to be altered

[#19](https://github.com/itsnubix/react-native-video-controls/issues/19)
- Updated requirements to RN 0.42.x and RN Video 1.0.0






## 1.1.1 (23-12-2016)

Restore playInBackground and playWhenInactive
Expand Down
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,8 @@ The `<VideoPlayer>` component can take a number of inputs to customize it as nee
style={ {} } // Style appended to <View> container

// event callbacks
onLoadStart={ () => {} } // Fired when loading of the source starts
onProgress={ () => {} } // Fired every ~250ms when the video progresses
onError={ () => {} } // Fired when an error is encountered on load
onBack={ () => {} } // Function fired when back button is pressed.
onLoad={ () => {} } // Fired when loading is complete
onEnd={ () => {} } // Fired when the video is complete.

/>
Expand Down
6 changes: 3 additions & 3 deletions VideoPlayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ export default class VideoPlayer extends Component {
* Our app listeners and associated methods
*/
this.events = {
onLoadStart: this.props.onLoadStart || this._onLoadStart.bind( this ),
onProgress: this.props.onProgress || this._onProgress.bind( this ),
onError: this.props.onError || this._onError.bind( this ),
onLoad: this.props.onLoad || this._onLoad.bind( this ),
onEnd: this.props.onEnd || this._onEnd.bind( this ),
onScreenPress: this._onScreenPress.bind( this ),
onLoadStart: this._onLoadStart.bind( this ),
onProgress: this._onProgress.bind( this ),
onLoad: this._onLoad.bind( this ),
};

/**
Expand Down
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"name": "react-native-video-controls",
"version": "1.1.1",
"version": "1.2.1",
"description": "A set of GUI controls for the react-native-video component",
"license": "MIT",
"main": "VideoPlayer.js",
"keywords": [
"react-native",
"react-native-video",
"react video controls",
"react video player"
"react-native",
"react-native-video",
"react video controls",
"react video player"
],
"scripts": {
"test": "echo \"No test specified\" && exit 1"
Expand All @@ -19,10 +19,10 @@
"url": "git@github.com:itsnubix/react-native-video-controls.git"
},
"dependencies": {
"lodash": "^4.16.4",
"react-native-video": "git+https://github.com/react-native-community/react-native-video.git#master"
"lodash": "^4.16.4",
"react-native-video": "^1.0.0"
},
"peerDependencies": {
"react-native": "^0.39.2"
"react-native": "^0.42.0"
}
}

0 comments on commit aaa09de

Please sign in to comment.