Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Extending DB Drivers #5

Closed
a-h-abid opened this issue Dec 25, 2013 · 4 comments
Closed

[Enhancement] Extending DB Drivers #5

a-h-abid opened this issue Dec 25, 2013 · 4 comments

Comments

@a-h-abid
Copy link

Liking your extended CI... pretty much everything we use in CI is there and mainly because of multisite support.

I'm looking for option to extend db drivers, which is even missing in main CI framework. So we structure it in same way as in system folder to extend in APP folder.

application/site/database/drivers/{driver_name}/

There are few functionality i want to add to my mysql driver, among them insert_duplicate_update() is one of them. And there is also this count_totals_from_last_query() + some more.

See if it can be done.

@ivantcholakov
Copy link
Owner

As I can see, you want to swap the database driver with your custom implementation. It is a legitime demand. I'll think about how this is to be implemented soon.

ivantcholakov added a commit that referenced this issue Dec 25, 2013
ivantcholakov added a commit that referenced this issue Dec 25, 2013
@ivantcholakov
Copy link
Owner

I think, the solution for you is ready.

ivantcholakov added a commit to ivantcholakov/starter-public-edition-3 that referenced this issue Dec 25, 2013
@a-h-abid
Copy link
Author

Nice. That was fast, thanks :). I'll check and let know if any issues found.

@ivantcholakov
Copy link
Owner

Since @narfbg is going to implement this feature directly on a future version CodeIgniter 3, I don't see a reason for keeping this issue open.

Please, consider what I've proposed as a temporary solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants