Skip to content

Support for IPython 3.0 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2015
Merged

Support for IPython 3.0 #119

merged 6 commits into from
May 31, 2015

Conversation

jjhelmus
Copy link
Contributor

No description provided.

@jjhelmus
Copy link
Contributor Author

IPython 3.0 changed a number of kernel related functionality which require updates. Current commit allow the plugin to find the kernel with the :IPython command and monitor the subchannel. Still need to fix tab completion and test other features.

@benjaminvdb
Copy link

It sounds like you're doing a fantastic job, jjhelmus! Thanks so much for taking the time. I'm pretty much dependent on vim-ipython, but I don't have much time to tinker with it.

@jjhelmus
Copy link
Contributor Author

jjhelmus commented May 8, 2015

All the features I've tested are working on IPython 3.1.0. Let me know if there is anything I missed.

@jjhelmus jjhelmus changed the title Work in progress, support for IPython 3.0 Support for IPython 3.0 May 8, 2015
Fixed issue where completions that occur not at the end of line where
incorrectly completing at the end of the line.
@jjhelmus
Copy link
Contributor Author

@ivanov Can this be reviewed for possible merging?

@ivanov
Copy link
Owner

ivanov commented May 31, 2015

this seems reasonable, thanks for pitching in @jjhelmus

ivanov added a commit that referenced this pull request May 31, 2015
Support for IPython 3.0, thanks to @jjhelmus
@ivanov ivanov merged commit 5876b48 into ivanov:master May 31, 2015
This was referenced Jul 26, 2015
@dajuno
Copy link

dajuno commented Jul 27, 2015

Here vim-ipython does not work for vim compiled for python3 (ArchLinux gvim-python3 package). Maybe it's not supposed to work since has('python') is 0, but has('python3') == 1, which I put into the ipy.vim...

Error detected while processing /home/david/.vim/bundle/vim-ipython/ftplugin/python/ipy.vim:
line   44:
E319: Sorry, the command is not available in this version: python << EOF
line   45:
E492: Not an editor command: import vim
line   46:
E492: Not an editor command: import sys
"=" [New File]
Cannot open file "="
"vim.eval("expand('/home/david/.vim/bundle/vim-ipython/ftplugin/python')")" [New DIRECTORY]
Cannot open file "vim.eval("expand('/home/david/.vim/bundle/vim-ipython/ftplugin/python')")"
line   47:
E480: No match: _ipython_path
line   48:
E492: Not an editor command: sys.path.append(vim_ipython_path)
line   49:
E492: Not an editor command: from vim_ipython import *
line   51:
E492: Not an editor command: EOF

When I used vim compiled with python2, vim-ipython didn't work either for ipython3, telling me that vim and ipython had to be using the same python installation...
So how would it work, then? Suggestions? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants