Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: like hover color, button size and skeleton UI for card #227

Merged
merged 9 commits into from
Jul 28, 2023
Merged

fix: like hover color, button size and skeleton UI for card #227

merged 9 commits into from
Jul 28, 2023

Conversation

revengemiroz
Copy link
Collaborator

@revengemiroz revengemiroz commented Jul 24, 2023 •
edited
Loading

Description

  • Fix : Skeloton of card not matching the ui
  • Fix : On hover links on navbar theres no hover color
  • Fix : Remove unused codes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Showcase

Please attach a picture or a video showing what this change does.

@vercel
Copy link

vercel bot commented Jul 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-shelf-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 3:01pm
project-shelf-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 3:01pm

ivanms1
ivanms1 requested changes Jul 27, 2023
View reviewed changes
Copy link
Owner

@ivanms1 ivanms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename PR to a more descriptive name

apps/web/src/components/Overlay/Overlay.tsx Outdated Show resolved Hide resolved
packages/ui/Button/index.tsx Outdated Show resolved Hide resolved
packages/ui/Button/index.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/Home/Home.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/Home/Home.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/Home/Home.tsx Outdated Show resolved Hide resolved
@revengemiroz revengemiroz self-assigned this Jul 28, 2023
@revengemiroz revengemiroz added bug Something isn't working fix labels Jul 28, 2023
@revengemiroz revengemiroz changed the title Minor/fix UI fix like hover color, button size and skeleton UI for card Jul 28, 2023
@ivanms1 ivanms1 changed the title UI fix like hover color, button size and skeleton UI for card fix: like hover color, button size and skeleton UI for card Jul 28, 2023
@ivanms1 ivanms1 merged commit 5aec216 into develop Jul 28, 2023
5 checks passed
@ivanms1 ivanms1 deleted the minor/fix branch July 28, 2023 15:03
@ivanms1 ivanms1 mentioned this pull request Jul 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanms1 ivanms1 ivanms1 approved these changes

Assignees

@revengemiroz revengemiroz

Labels
bug Something isn't working fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@revengemiroz @ivanms1