Fix change overload order to allow correct type hinting (Mistaken PR) #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ivan,
To fix the issue Type hint broken for inject.attr when using ABCMeta just change the order of typing overloads. From more specific to more abstract.
Hasheable
type can match withType[T]
. To prevent that, just declare firstHasheable
overload andType[T]
later:I have change this (in all
@overload
declarations):To this:
Cheers! :)