Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing data in preprocessing for SC segmentation task #18

Merged
merged 7 commits into from
Dec 17, 2021

Conversation

uzaymacar
Copy link
Contributor

@uzaymacar uzaymacar commented Dec 17, 2021

This PR introduces modifications to preprocess/preprocess_data.sh to such that it prepares a cleaned data processed folder for carrying out spinal cord (SC) segmentation. More explicitly, a user input argument <TASK> is added for specifying whether the preprocessing prepares data for lesion segmentation (lesionseg) or SC segmentation (scseg). For scseg, we copy raw subject images as inputs and SC masks as target labels. More documentation on how to run can be found in the modified README.md in this PR.

It is important to note that we have subjects with and without manually-corrected SC segmentations. This means that for some subjects, the ground-truth will be taken as the output of sct_deepseg_sc. This might be reasonable because these segmentations were marked "good to go" by @jcohenadad during SCT quality-control.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice-- just this to address #18 (review)

@uzaymacar
Copy link
Contributor Author

uzaymacar commented Dec 17, 2021

The last five commits implement copying the relevant JSON for the SC segmentations s.t. we use the auto-generated JSON for manually corrected and create a new JSON for sct_deepseg_sc generated SC segmentations. I re-tested out training with the um/ivadomed_scseg_training branch and it works. The newly created JSONs (XXX_seg-manual.json) have the following form:

{
    "Author": "Generated with sct_deepseg_sc",
    "Date": "2021-12-17 16:40:34"
}

This form is equivalent to the one outputted by the manual correction script.

Hey @jcohenadad, is this okay from a convention perspective?

@jcohenadad
Copy link
Member

Hey @jcohenadad, is this okay from a convention perspective?

this is great!

@uzaymacar uzaymacar merged commit 7190e0f into main Dec 17, 2021
@uzaymacar uzaymacar deleted the um/preprocessing_for_scseg branch December 17, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants